undeclared build-time dependency on libnumbertext 1.0.6

[Rene Engelhard <rene@xxxxxxxxxx>]

Hi,

my LO 7.0.0 build on Debian buster failed:

[...]
Test name: SwUiWriterTest::testTdf133589
equality assertion failed
- Expected: 𐳥𐳋𐳓𐳉𐳗
- Actual  : székely 0

Failures !!!
Run: 305   Failure total: 1   Failures: 1   Errors: 0

This looks like libnumbertext needs to be 1.0.6 which does have this new
"old hungarian" feature... (yes, "of course" --with-system-libnumbertext
and libnumbertext in Debian buster is 1.0.5).

$ git diff
diff --git a/configure.ac b/configure.ac
index 59ec7ec58bf1..d5782d32be4b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10509,7 +10509,7 @@ AC_SUBST(SYSTEM_LIBEXTTEXTCAT_DATA)
 dnl ===================================================================
 dnl Checking for libnumbertext
 dnl ===================================================================
-libo_CHECK_SYSTEM_MODULE([libnumbertext],[LIBNUMBERTEXT],[libnumbertext
>= 1.0.0])
+libo_CHECK_SYSTEM_MODULE([libnumbertext],[LIBNUMBERTEXT],[libnumbertext
>= 1.0.6])
 if test "$with_system_libnumbertext" = "yes"; then
     SYSTEM_LIBNUMBERTEXT_DATA=file://`$PKG_CONFIG --variable=pkgdatadir
libnumbertext`
     SYSTEM_LIBNUMBERTEXT=YES

The other alternative is to do it like the DLP libraries and only do the
test needing it if libnumbertext is 1.0.6 and thus support "old
hungarian"...

Which one would you prefer? The first one of course is trivial :-)

Regards,

Rene
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice