Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
16 new defect(s) introduced to LibreOffice found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 16 of 16 defect(s)
** CID 1465241: Error handling issues (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 791 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
________________________________________________________________________________________________________
*** CID 1465241: Error handling issues (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 791 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
785
786 if ( DGTSubmission == m_eGroup )
787 {
788 try
789 {
790 std::unique_ptr<weld::TreeIter> xEntry(m_xItemList->make_iterator());
>>> CID 1465241: Error handling issues (CHECKED_RETURN)
>>> Calling "get_selected" without checking return value (as is done elsewhere 77 out of 94 times).
791 m_xItemList->get_selected(xEntry.get());
792
793 // #i36262# may be called for submission entry *or* for
794 // submission children. If we don't have any children, we
795 // assume the latter case and use the parent
796 if (!m_xItemList->iter_has_child(*xEntry))
** CID 1465240: Control flow issues (DEADCODE)
/vcl/source/gdi/pdfwriter_impl.cxx: 595 in vcl::<unnamed>::appendPdfTimeDate(rtl::OStringBuffer &, short, unsigned short, unsigned short, unsigned short, unsigned short, unsigned short, unsigned int)()
________________________________________________________________________________________________________
*** CID 1465240: Control flow issues (DEADCODE)
/vcl/source/gdi/pdfwriter_impl.cxx: 595 in vcl::<unnamed>::appendPdfTimeDate(rtl::OStringBuffer &, short, unsigned short, unsigned short, unsigned short, unsigned short, unsigned short, unsigned int)()
589 }
590 else
591 {
592 if (tzDelta > 0 )
593 rBuffer.append("+");
594 else
>>> CID 1465240: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "rBuffer->append("-");".
595 rBuffer.append("-");
596
597 rBuffer.append(char('0' + ((tzDelta / 36000) % 10)));
598 rBuffer.append(char('0' + ((tzDelta / 3600) % 10)));
599 rBuffer.append("'");
600 rBuffer.append(char('0' + ((tzDelta / 600) % 6)));
** CID 1465239: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 1465239: Null pointer dereferences (FORWARD_NULL)
/vcl/source/filter/ipdf/pdfdocument.cxx: 360 in vcl::filter::PDFDocument::WriteAppearanceObject(tools::Rectangle &)()
354 aEditBuffer.WriteCharPtr("<</Type/XObject\n/Subtype/Form\n");
355
356 PDFObjectCopier aCopier(*this);
357 if (!aContentStreams.empty())
358 {
359 OStringBuffer aBuffer;
>>> CID 1465239: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pPage" to "copyPageResources", which dereferences it.
360 aCopier.copyPageResources(pPage, aBuffer);
361 aEditBuffer.WriteOString(aBuffer.makeStringAndClear());
362 }
363
364 aEditBuffer.WriteCharPtr("/BBox[0 0 ");
365 aEditBuffer.WriteOString(OString::number(rSignatureRectangle.getWidth()));
** CID 1465238: Uninitialized members (UNINIT_CTOR)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 155 in chart::VSeriesPlotter::VSeriesPlotter(const com::sun::star::uno::Reference<com::sun::star::chart2::XChartType> &, int, bool)()
________________________________________________________________________________________________________
*** CID 1465238: Uninitialized members (UNINIT_CTOR)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 155 in chart::VSeriesPlotter::VSeriesPlotter(const com::sun::star::uno::Reference<com::sun::star::chart2::XChartType> &, int, bool)()
149 , m_aNullDate(30,12,1899)
150 , m_xColorScheme()
151 , m_pExplicitCategoriesProvider(nullptr)
152 , m_bPointsWereSkipped(false)
153 {
154 SAL_WARN_IF(!m_xChartTypeModel.is(),"chart2","no XChartType available in view, fallback to default values may be wrong");
>>> CID 1465238: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_bPieLabelsAllowToMove" is not initialized in this constructor nor in any functions that it calls.
155 }
156
157 VSeriesPlotter::~VSeriesPlotter()
158 {
159 //delete all data series help objects:
160 for (std::vector<VDataSeriesGroup> & rGroupVector : m_aZSlots)
** CID 1465237: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 1465237: Null pointer dereferences (FORWARD_NULL)
/svl/source/numbers/zforlist.cxx: 3051 in SvNumberFormatter::GenerateFormat(unsigned int, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool, bool, unsigned short, unsigned short)()
3045
3046 OUStringBuffer sString;
3047 using comphelper::string::padToLength;
3048
3049 if (eType & SvNumFormatType::TIME)
3050 {
>>> CID 1465237: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pFormat" to "GetFormatStringForTimePrecision", which dereferences it.
3051 sString = pFormat->GetFormatStringForTimePrecision( nPrecision );
3052 }
3053 else if (nLeadingZeros == 0)
3054 {
3055 if (!bThousand)
3056 sString.append('#');
** CID 1465236: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/tool/scopetools.cxx: 88 in sc::DelayStartListeningFormulaCells::~DelayStartListeningFormulaCells()()
________________________________________________________________________________________________________
*** CID 1465236: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/core/tool/scopetools.cxx: 88 in sc::DelayStartListeningFormulaCells::~DelayStartListeningFormulaCells()()
82
83 DelayStartListeningFormulaCells::DelayStartListeningFormulaCells(ScColumn& column)
84 : mColumn(column), mbOldValue(column.GetDoc()->IsEnabledDelayStartListeningFormulaCells(&column))
85 {
86 }
87
>>> CID 1465236: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
88 DelayStartListeningFormulaCells::~DelayStartListeningFormulaCells()
89 {
90 mColumn.GetDoc()->EnableDelayStartListeningFormulaCells(&mColumn, mbOldValue);
91 }
92
93 void DelayStartListeningFormulaCells::set()
** CID 1465235: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1465235: Null pointer dereferences (NULL_RETURNS)
/cui/source/dialogs/hltpbase.cxx: 334 in SvxHyperlinkTabPageBase::ClickScriptHdl_Impl(weld::Button &)()
328 // Click on imagebutton : Script
329 IMPL_LINK_NOARG(SvxHyperlinkTabPageBase, ClickScriptHdl_Impl, weld::Button&, void)
330 {
331 SvxHyperlinkItem *pHyperlinkItem = const_cast<SvxHyperlinkItem*>(static_cast<const SvxHyperlinkItem *>(
332 GetItemSet().GetItem (SID_HYPERLINK_GETLINK)));
333
>>> CID 1465235: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pHyperlinkItem" when calling "GetMacroEvents".
334 if ( pHyperlinkItem->GetMacroEvents() == HyperDialogEvent::NONE )
335 return;
336
337 // get macros from itemset
338 const SvxMacroTableDtor* pMacroTbl = pHyperlinkItem->GetMacroTable();
339 SvxMacroItem aItem ( SID_ATTR_MACROITEM );
** CID 1465234: Error handling issues (CHECKED_RETURN)
/svx/source/form/navigatortree.cxx: 1898 in svxform::NavigatorTree::SynchronizeMarkList()()
________________________________________________________________________________________________________
*** CID 1465234: Error handling issues (CHECKED_RETURN)
/svx/source/form/navigatortree.cxx: 1898 in svxform::NavigatorTree::SynchronizeMarkList()()
1892 // if exactly one form is selected now, shell should notice it as CurrentForm
1893 // (if selection handling isn't locked, view cares about it in MarkListHasChanged
1894 // but mechanism doesn't work, if form is empty for example
1895 if ((m_arrCurrentSelection.size() == 1) && (m_nFormsSelected == 1))
1896 {
1897 std::unique_ptr<weld::TreeIter> xSelected(m_xTreeView->make_iterator());
>>> CID 1465234: Error handling issues (CHECKED_RETURN)
>>> Calling "get_selected" without checking return value (as is done elsewhere 77 out of 94 times).
1898 m_xTreeView->get_selected(xSelected.get());
1899 FmFormData* pSingleSelectionData = dynamic_cast<FmFormData*>(reinterpret_cast<FmEntryData*>(m_xTreeView->get_id(*xSelected).toInt64()));
1900 DBG_ASSERT( pSingleSelectionData, "NavigatorTree::SynchronizeMarkList: invalid selected form!" );
1901 if ( pSingleSelectionData )
1902 {
1903 InterfaceBag aSelection;
** CID 1465233: Error handling issues (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 804 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
________________________________________________________________________________________________________
*** CID 1465233: Error handling issues (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 804 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
798
799 _rEntry->getPropertyValue( PN_SUBMISSION_ID ) >>= sTemp;
800 m_xItemList->set_text(*xEntry, sTemp);
801
802 _rEntry->getPropertyValue( PN_SUBMISSION_BIND ) >>= sTemp;
803 OUString sEntry = SvxResId( RID_STR_DATANAV_SUBM_BIND ) + sTemp;
>>> CID 1465233: Error handling issues (CHECKED_RETURN)
>>> Calling "iter_children" without checking return value (as is done elsewhere 45 out of 47 times).
804 m_xItemList->iter_children(*xEntry);
805 m_xItemList->set_text(*xEntry, sEntry);
806 _rEntry->getPropertyValue( PN_SUBMISSION_REF ) >>= sTemp;
807 sEntry = SvxResId( RID_STR_DATANAV_SUBM_REF ) + sTemp;
808 m_xItemList->iter_next_sibling(*xEntry);
809 m_xItemList->set_text(*xEntry, sEntry);
** CID 1465232: (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1465232: (NULL_RETURNS)
/cui/source/tabpages/border.cxx: 869 in SvxBorderTabPage::FillItemSet(SfxItemSet *)()
863 }
864
865 if (m_xShadowControls && m_xShadowControls->get_value_changed_from_saved())
866 {
867 sal_uInt16 nShadowId = pPool->GetWhich(mnShadowSlot);
868 const SvxShadowItem& rOldShadowItem = *static_cast<const SvxShadowItem*>(rCoreAttrs->GetItem(nShadowId));
>>> CID 1465232: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "rOldShadowItem" when calling "GetControlValue".
869 rCoreAttrs->Put(m_xShadowControls->GetControlValue(rOldShadowItem));
870 bAttrsChanged = true;
871 }
872
873 if (m_xMarginControls && m_xMarginControls->get_value_changed_from_saved())
874 {
/cui/source/tabpages/border.cxx: 859 in SvxBorderTabPage::FillItemSet(SfxItemSet *)()
853 bAttrsChanged = true;
854 }
855
856 if (m_aFrameSel.IsBorderEnabled(svx::FrameBorderType::BLTR))
857 {
858 sal_uInt16 nBorderDiagId = pPool->GetWhich(SID_ATTR_BORDER_DIAG_BLTR);
>>> CID 1465232: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "static_cast<SvxLineItem const *>(rCoreAttrs->GetItem(nBorderDiagId, true))" when calling "SvxLineItem".
859 SvxLineItem aLineItem(*static_cast<const SvxLineItem*>(rCoreAttrs->GetItem(nBorderDiagId)));
860 aLineItem.SetLine(m_aFrameSel.GetFrameBorderStyle(svx::FrameBorderType::BLTR));
861 rCoreAttrs->Put(aLineItem);
862 bAttrsChanged = true;
863 }
864
/cui/source/tabpages/border.cxx: 877 in SvxBorderTabPage::FillItemSet(SfxItemSet *)()
871 }
872
873 if (m_xMarginControls && m_xMarginControls->get_value_changed_from_saved())
874 {
875 sal_uInt16 nAlignMarginId = pPool->GetWhich(SID_ATTR_ALIGN_MARGIN);
876 const SvxMarginItem& rOldMarginItem = *static_cast<const SvxMarginItem*>(rCoreAttrs->GetItem(nAlignMarginId));
>>> CID 1465232: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "rOldMarginItem" when calling "GetControlValue".
877 rCoreAttrs->Put(m_xMarginControls->GetControlValue(rOldMarginItem));
878 bAttrsChanged = true;
879 }
880
881 if (m_xMergeAdjacentBordersCB->get_state_changed_from_saved())
882 {
/cui/source/tabpages/border.cxx: 850 in SvxBorderTabPage::FillItemSet(SfxItemSet *)()
844
845 SfxItemPool* pPool = rCoreAttrs->GetPool();
846
847 if (m_aFrameSel.IsBorderEnabled(svx::FrameBorderType::TLBR))
848 {
849 sal_uInt16 nBorderDiagId = pPool->GetWhich(SID_ATTR_BORDER_DIAG_TLBR);
>>> CID 1465232: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "static_cast<SvxLineItem const *>(rCoreAttrs->GetItem(nBorderDiagId, true))" when calling "SvxLineItem".
850 SvxLineItem aLineItem(*static_cast<const SvxLineItem*>(rCoreAttrs->GetItem(nBorderDiagId)));
851 aLineItem.SetLine(m_aFrameSel.GetFrameBorderStyle(svx::FrameBorderType::TLBR));
852 rCoreAttrs->Put(aLineItem);
853 bAttrsChanged = true;
854 }
855
** CID 1465231: (NEGATIVE_RETURNS)
________________________________________________________________________________________________________
*** CID 1465231: (NEGATIVE_RETURNS)
/writerfilter/source/dmapper/NumberingManager.cxx: 714 in writerfilter::dmapper::ListsManager::lcl_attribute(unsigned int, writerfilter::Value &)()
708 break;
709 case NS_ooxml::LN_CT_AbstractNum_tmpl:
710 AbstractListDef::SetValue( nName );
711 break;
712 case NS_ooxml::LN_CT_NumLvl_ilvl:
713 //add a new level to the level vector and make it the current one
>>> CID 1465231: (NEGATIVE_RETURNS)
>>> "rtl::OUString(rVal->getString()).toInt32(10)" is passed to a parameter that cannot be negative.
714 m_pCurrentDefinition->AddLevel(rVal.getString().toInt32());
715 break;
716 case NS_ooxml::LN_CT_Lvl_ilvl:
717 m_pCurrentDefinition->AddLevel(rVal.getString().toInt32());
718 break;
719 case NS_ooxml::LN_CT_AbstractNum_abstractNumId:
/writerfilter/source/dmapper/NumberingManager.cxx: 717 in writerfilter::dmapper::ListsManager::lcl_attribute(unsigned int, writerfilter::Value &)()
711 break;
712 case NS_ooxml::LN_CT_NumLvl_ilvl:
713 //add a new level to the level vector and make it the current one
714 m_pCurrentDefinition->AddLevel(rVal.getString().toInt32());
715 break;
716 case NS_ooxml::LN_CT_Lvl_ilvl:
>>> CID 1465231: (NEGATIVE_RETURNS)
>>> "rtl::OUString(rVal->getString()).toInt32(10)" is passed to a parameter that cannot be negative.
717 m_pCurrentDefinition->AddLevel(rVal.getString().toInt32());
718 break;
719 case NS_ooxml::LN_CT_AbstractNum_abstractNumId:
720 {
721 // This one corresponds to the AbstractNum Id definition
722 // The reference to the abstract num is in the sprm method
** CID 1465230: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1465230: Null pointer dereferences (NULL_RETURNS)
/cui/source/dialogs/hltpbase.cxx: 385 in SvxHyperlinkTabPageBase::GetMacroEvents() const()
379 // Get Macro-Infos
380 HyperDialogEvent SvxHyperlinkTabPageBase::GetMacroEvents() const
381 {
382 const SvxHyperlinkItem *pHyperlinkItem = static_cast<const SvxHyperlinkItem *>(
383 GetItemSet().GetItem (SID_HYPERLINK_GETLINK));
384
>>> CID 1465230: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pHyperlinkItem" when calling "GetMacroEvents".
385 return pHyperlinkItem->GetMacroEvents();
386 }
387
388 SvxMacroTableDtor* SvxHyperlinkTabPageBase::GetMacroTable()
389 {
390 const SvxHyperlinkItem *pHyperlinkItem = static_cast<const SvxHyperlinkItem *>(
** CID 1465229: Error handling issues (CHECKED_RETURN)
/svx/source/form/navigatortree.cxx: 714 in svxform::NavigatorTree::implAcceptPaste()()
________________________________________________________________________________________________________
*** CID 1465229: Error handling issues (CHECKED_RETURN)
/svx/source/form/navigatortree.cxx: 714 in svxform::NavigatorTree::implAcceptPaste()()
708
709 // get the clipboard
710 TransferableDataHelper aClipboardContent(TransferableDataHelper::CreateFromClipboard(GetSystemClipboard()));
711
712 sal_Int8 nAction = m_aControlExchange.isClipboardOwner() && doingKeyboardCut( ) ? DND_ACTION_MOVE : DND_ACTION_COPY;
713 std::unique_ptr<weld::TreeIter> xSelected(m_xTreeView->make_iterator());
>>> CID 1465229: Error handling issues (CHECKED_RETURN)
>>> Calling "get_selected" without checking return value (as is done elsewhere 77 out of 94 times).
714 m_xTreeView->get_selected(xSelected.get());
715 return nAction == implAcceptDataTransfer(aClipboardContent.GetDataFlavorExVector(), nAction, xSelected.get(), false);
716 }
717
718 sal_Int8 NavigatorTree::implAcceptDataTransfer( const DataFlavorExVector& _rFlavors, sal_Int8 _nAction, weld::TreeIter* _pTargetEntry, bool _bDnD )
719 {
** CID 1465228: (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 808 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
/svx/source/form/datanavi.cxx: 816 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
/svx/source/form/datanavi.cxx: 812 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
/svx/source/form/datanavi.cxx: 821 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
________________________________________________________________________________________________________
*** CID 1465228: (CHECKED_RETURN)
/svx/source/form/datanavi.cxx: 808 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
802 _rEntry->getPropertyValue( PN_SUBMISSION_BIND ) >>= sTemp;
803 OUString sEntry = SvxResId( RID_STR_DATANAV_SUBM_BIND ) + sTemp;
804 m_xItemList->iter_children(*xEntry);
805 m_xItemList->set_text(*xEntry, sEntry);
806 _rEntry->getPropertyValue( PN_SUBMISSION_REF ) >>= sTemp;
807 sEntry = SvxResId( RID_STR_DATANAV_SUBM_REF ) + sTemp;
>>> CID 1465228: (CHECKED_RETURN)
>>> Calling "iter_next_sibling" without checking return value (as is done elsewhere 53 out of 58 times).
808 m_xItemList->iter_next_sibling(*xEntry);
809 m_xItemList->set_text(*xEntry, sEntry);
810 _rEntry->getPropertyValue( PN_SUBMISSION_ACTION ) >>= sTemp;
811 sEntry = SvxResId( RID_STR_DATANAV_SUBM_ACTION ) + sTemp;
812 m_xItemList->iter_next_sibling(*xEntry);
813 _rEntry->getPropertyValue( PN_SUBMISSION_METHOD ) >>= sTemp;
/svx/source/form/datanavi.cxx: 816 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
810 _rEntry->getPropertyValue( PN_SUBMISSION_ACTION ) >>= sTemp;
811 sEntry = SvxResId( RID_STR_DATANAV_SUBM_ACTION ) + sTemp;
812 m_xItemList->iter_next_sibling(*xEntry);
813 _rEntry->getPropertyValue( PN_SUBMISSION_METHOD ) >>= sTemp;
814 sEntry = SvxResId( RID_STR_DATANAV_SUBM_METHOD ) +
815 m_aMethodString.toUI( sTemp );
>>> CID 1465228: (CHECKED_RETURN)
>>> Calling "iter_next_sibling" without checking return value (as is done elsewhere 53 out of 58 times).
816 m_xItemList->iter_next_sibling(*xEntry);
817 m_xItemList->set_text(*xEntry, sEntry);
818 _rEntry->getPropertyValue( PN_SUBMISSION_REPLACE ) >>= sTemp;
819 sEntry = SvxResId( RID_STR_DATANAV_SUBM_REPLACE ) +
820 m_aReplaceString.toUI( sTemp );
821 m_xItemList->iter_next_sibling(*xEntry);
/svx/source/form/datanavi.cxx: 812 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
806 _rEntry->getPropertyValue( PN_SUBMISSION_REF ) >>= sTemp;
807 sEntry = SvxResId( RID_STR_DATANAV_SUBM_REF ) + sTemp;
808 m_xItemList->iter_next_sibling(*xEntry);
809 m_xItemList->set_text(*xEntry, sEntry);
810 _rEntry->getPropertyValue( PN_SUBMISSION_ACTION ) >>= sTemp;
811 sEntry = SvxResId( RID_STR_DATANAV_SUBM_ACTION ) + sTemp;
>>> CID 1465228: (CHECKED_RETURN)
>>> Calling "iter_next_sibling" without checking return value (as is done elsewhere 53 out of 58 times).
812 m_xItemList->iter_next_sibling(*xEntry);
813 _rEntry->getPropertyValue( PN_SUBMISSION_METHOD ) >>= sTemp;
814 sEntry = SvxResId( RID_STR_DATANAV_SUBM_METHOD ) +
815 m_aMethodString.toUI( sTemp );
816 m_xItemList->iter_next_sibling(*xEntry);
817 m_xItemList->set_text(*xEntry, sEntry);
/svx/source/form/datanavi.cxx: 821 in svxform::XFormsPage::EditEntry(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
815 m_aMethodString.toUI( sTemp );
816 m_xItemList->iter_next_sibling(*xEntry);
817 m_xItemList->set_text(*xEntry, sEntry);
818 _rEntry->getPropertyValue( PN_SUBMISSION_REPLACE ) >>= sTemp;
819 sEntry = SvxResId( RID_STR_DATANAV_SUBM_REPLACE ) +
820 m_aReplaceString.toUI( sTemp );
>>> CID 1465228: (CHECKED_RETURN)
>>> Calling "iter_next_sibling" without checking return value (as is done elsewhere 53 out of 58 times).
821 m_xItemList->iter_next_sibling(*xEntry);
822 m_xItemList->set_text(*xEntry, sEntry);
823 }
824 catch ( Exception const & )
825 {
826 TOOLS_WARN_EXCEPTION( "svx.form", "XFormsPage::EditEntry()" );
** CID 1448540: (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1448540: (NULL_RETURNS)
/sw/source/uibase/uiview/viewtab.cxx: 2425 in SwView::StateTabWin(SfxItemSet &)()
2419 const SvxLRSpaceItem* rLR = static_cast<const SvxLRSpaceItem*>(
2420 rHeader.GetHeaderFormat()->GetAttrSet().GetItem(SID_ATTR_LRSPACE));
2421 const SvxULSpaceItem* rUL = static_cast<const SvxULSpaceItem*>(
2422 rHeader.GetHeaderFormat()->GetAttrSet().GetItem(SID_ATTR_ULSPACE));
2423 SvxLongLRSpaceItem aLR(rLR->GetLeft(), rLR->GetRight(), SID_ATTR_PAGE_HEADER_LRMARGIN);
2424 rSet.Put(aLR);
>>> CID 1448540: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "rUL" when calling "GetUpper".
2425 SvxLongULSpaceItem aUL( rUL->GetUpper(), rUL->GetLower(), SID_ATTR_PAGE_HEADER_SPACING);
2426 rSet.Put(aUL);
2427
2428 bool bShared = !rDesc.IsHeaderShared();
2429 bool bFirst = !rDesc.IsFirstShared(); // FIXME control changes for both header footer - tdf#100287
2430 sal_uInt16 nLayout = (static_cast<int>(bShared)<<1) + static_cast<int>(bFirst);
/sw/source/uibase/uiview/viewtab.cxx: 2423 in SwView::StateTabWin(SfxItemSet &)()
2417 if(bHeaderOn)
2418 {
2419 const SvxLRSpaceItem* rLR = static_cast<const SvxLRSpaceItem*>(
2420 rHeader.GetHeaderFormat()->GetAttrSet().GetItem(SID_ATTR_LRSPACE));
2421 const SvxULSpaceItem* rUL = static_cast<const SvxULSpaceItem*>(
2422 rHeader.GetHeaderFormat()->GetAttrSet().GetItem(SID_ATTR_ULSPACE));
>>> CID 1448540: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "rLR" when calling "GetLeft".
2423 SvxLongLRSpaceItem aLR(rLR->GetLeft(), rLR->GetRight(), SID_ATTR_PAGE_HEADER_LRMARGIN);
2424 rSet.Put(aLR);
2425 SvxLongULSpaceItem aUL( rUL->GetUpper(), rUL->GetLower(), SID_ATTR_PAGE_HEADER_SPACING);
2426 rSet.Put(aUL);
2427
2428 bool bShared = !rDesc.IsHeaderShared();
** CID 1448269: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1448269: Null pointer dereferences (NULL_RETURNS)
/sd/source/ui/view/drviews7.cxx: 1716 in sd::DrawViewShell::GetPageProperties(SfxItemSet &)()
1710 rSet.Put(aFillStyleItem);
1711
1712 switch (eXFS)
1713 {
1714 case drawing::FillStyle_SOLID:
1715 {
>>> CID 1448269: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "rPageAttr->GetItem(XATTR_FILLCOLOR, true)" when calling "GetColorValue".
1716 Color aColor = rPageAttr.GetItem( XATTR_FILLCOLOR )->GetColorValue();
1717 XFillColorItem aFillColorItem( OUString(), aColor );
1718 aFillColorItem.SetWhich( SID_ATTR_PAGE_COLOR );
1719 rSet.Put( aFillColorItem );
1720 }
1721 break;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teExViPHTTReBArhCRZ3BE4kCjKjDqn2Dq3ZyEbAvAs31gRpU3vMPHDnoSx68vDAWjNU-3Dq6YS_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJivptaC3cXKhBv1GbDisONf-2FhZUee-2F-2FNEKf7AsLT94YBf1cbgEt2MANDlLMIwPx3661S9lMuMlFfCzXTXq1IGYQww4W1cznZ6u2onKJdiCPM-2BxK65NVS87A4YKPD6kre9MGZzC5FfH620s7TH-2FJz6k-2Bvi0r-2BktVGaxpb04Wjk3D7Ux03PuHo9dTMsJi-2Bgv3-2F21
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: New Defects reported by Coverity Scan for LibreOffice
- From: scan-admin@xxxxxxxxxxxx
- Date: Thu, 09 Jul 2020 06:18:16 +0000 (UTC)
- Prev by Date: Re; Revised Quotation and confirm price in USD Asap !
- Next by Date: ESC minutes 2020-Jul-09
- Previous by thread: New Defects reported by Coverity Scan for LibreOffice
- Next by thread: New Defects reported by Coverity Scan for LibreOffice
- Index(es):
 |