Re: asserts removed

[Xisco Fauli <xiscofauli@xxxxxxxxxxxxxxx>]

Hello,

an update on this.

On 17/4/20 21:02, Xisco Fauli wrote:
> Hello all,
>
> To my surprise, I found while checking documents with glow effects that
> in f9fc420dceb1ece2c98767da16a21aaff771f140 three chunks of code were
> deleted in sw/qa/extras/ooxmlexport/ooxmlexport7.cxx. See
> https://cgit.freedesktop.org/libreoffice/core/diff/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx?id=f9fc420dceb1ece2c98767da16a21aaff771f140
>
> After some investigation I found:
>
> - First block: asserts checking the glow effect were removed <- just
> needed to be adapted.
>
> - Second block: even non glow effect asserts were removed <- This
> worries me more
>
> - Third block: glow effect is no longer exported, causing a regression
> <- also worries me

The regression was fixed by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=65f3aea4727123a75dbd471592fe711998b5209b
( kudos to Mike Kaganski ) and the unittest has been restored in
https://gerrit.libreoffice.org/c/core/+/93720.

Regards

-- 
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0

_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice