On 02/08/2019 19:09, Michael Meeks wrote:
Oh - that's simple, it's a chunk of work that for uninteresting, customer related reasons had to be done internally, and fiddling with and/or re-basing 27 stacked commits multiple times will either kill CI for everyone or if done one by one, take an extremely long time to get in, and/or would need squashing thus loosing the history and/or authorship; so I pushed just a terminal commit through gerrit / CI.
I did an experiment of running 80+ commits through Gerrit the other night, and didn't hear any complaints :)
One IMO great thing of pushing every individual commit through Gerrit is that it gives a convenient and obvious place where to discuss changes post commit. But yeah, there's no ideal solution for every case.
_______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice
