|
Hi Raal,
please have a look at the newest version of
https://gerrit.libreoffice.org/#/c/74333/
I've added tests of the "cancel" button to wherever other tests
check the work of that specific dialog.
As far as possible I tried not to open new documents for the new
test, but integrate into the existing tests.
Wherever it was easy I've added a short check if the "cancel"
button does not change anything obvious.
Greetings Artur
On 2019-06-25 9:02 p.m., Raal wrote:
Hi Artur,
yes, because longest time of uitest is initialize and open
LibreOffice.
Thank you
Regards,
Raal
On 25. 06. 19 13:30, Artur Neumann wrote:
Hi Raal,
so you would prefer if the "Cancel/Close" tests would be
integrated in other tests of that dialog if those exist like
I've done now
https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests/fillRandomNumber.py
https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests/sheetRename.py
https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests3/clearCells.py
If that is the case I will go through the list and change
that
Artur
On 2019-06-24 9:30 p.m., Raal
wrote:
Hi Raal & Markus
I've moved the tests into a new folder and skipped tests
that are already done in other tests. The lines have
comments explaining why specific tests are skipped. https://gerrit.libreoffice.org/#/c/74333/
If you thing testing the "Cancel" button does not make
sense, we can skip even more tests.
Please review and see if that makes sense to you.
Greetings Artur
On 2019-06-22 10:57 p.m., Raal
wrote:
Hello Artur,
I think that in general it is a good idea.
Depending on how long it takes to execute the test
we might need to think about whether we can
actually include the tests in a normal make/make
check or if they need to be treated differently.
Did you already have a chat with Raal who has been
writing tests for many bugs/dialogs already?
If yes I could extend the tests by:
- doing the same for writer, impress, etc.
- delete obsolete tests like
uitest/calc_tests/about_test.py
- define preconditions for the "OK" click,
e.g. input data into fields
- define assertion after the click on the
"OK" button
In general this sounds like a good idea. As
mentioned it might be good to have a chat with
Raal who might have an overview how far we are in
opening all dialogs already.
Regards,
Markus
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
LibreOffice is powered by a team of volunteers who mostly give their time for free.
We invite you to join as there are many ways to get involved including bugs triage,
marketing, UX, documentation, and of course developing - https://www.libreoffice.org/get-involved/
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it
--
LibreOffice is powered by a team of volunteers who mostly give their time for free.
We invite you to join as there are many ways to get involved including bugs triage,
marketing, UX, documentation, and of course developing - https://www.libreoffice.org/get-involved/
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it
--
LibreOffice is powered by a team of volunteers who mostly give their time for free.
We invite you to join as there are many ways to get involved including bugs triage,
marketing, UX, documentation, and of course developing - https://www.libreoffice.org/get-involved/
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it
|
