|
Hi Raal,
thank you for the advice. I thought of deleting obsolete tests
like uitest/calc_tests/about_test.py in the second step. But its
true, as the more complex tests have to be kept anywhere some of
the simple tests in my commit can be deleted.
The question is though if in some cases they still might be
valid. e.g. https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/calc_tests7/tdf123479.py
- does not check the "Cancel" button
- opens a document and selects a range before opening the
dialog, meaning testing an other scenario
I don't know enough of LO structure and what areas are bug-prone,
to make a judgment on whether in such a case an extra "Open
dialog, click cancel" and "Open dialog on an empty sheet, click
OK" tests are worth having.
What I will do then:
- go through the tests in https://gerrit.libreoffice.org/#/c/74333
and check which look not needed
- place it in a nee directory
- cleanup the list of tests marked "needUITest" in bugzilla
https://bugs.documentfoundation.org/buglist.cgi?include_fields=id&include_fields=summary&include_fields=priority&include_fields=status&keywords=needUITest&list_id=972536&order=bug_id&product=LibreOffice&resolution=FIXED
I had a go at some and found that tests already exists
- close https://gerrit.libreoffice.org/#/c/74026/
Greetings Artur
On 2019-06-22 10:57 p.m., Raal wrote:
Hello Artur,
I think that in general it is a good idea. Depending on
how long it takes to execute the test we might need to
think about whether we can actually include the tests in a
normal make/make check or if they need to be treated
differently. Did you already have a chat with Raal who has
been writing tests for many bugs/dialogs already?
If yes I could extend the tests by:
- doing the same for writer, impress, etc.
- delete obsolete tests like
uitest/calc_tests/about_test.py
- define preconditions for the "OK" click, e.g.
input data into fields
- define assertion after the click on the "OK"
button
In general this sounds like a good idea. As mentioned
it might be good to have a chat with Raal who might have
an overview how far we are in opening all dialogs already.
Regards,
Markus
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
LibreOffice is powered by a team of volunteers who mostly give their time for free.
We invite you to join as there are many ways to get involved including bugs triage,
marketing, UX, documentation, and of course developing - https://www.libreoffice.org/get-involved/
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it
|
