Re: Struggling with unit test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephan,

Stephan Bergmann schrieb am 14-May-19 um 09:30:
On 14/05/2019 02:32, Regina Henschel wrote:
I need help again. I try to write a unit test https://gerrit.libreoffice.org/#/c/72229/
It works with Windows10. But Jenkins fails on Mac with message
https://ci.libreoffice.org/job/gerrit_mac/32803/
[..]
What is needed for these systems? Does it make a difference whether it is a debug build or not? My current Windows setting is a non-debug build, in the Linux VM it is a debug-build.

In include/svx/svdoashp.hxx, the SdrObjCustomShape member functions GetInteractionHandles and DragMoveCustomShapeHdl are marked as SVX_DLLPRIVATE (i.e., SAL_DLLPRIVATE).  On Windows, that happens to have no effect, but on other platforms it prevents those symbols from being exported from the svxcore library, so you can't actually access those functions from test code.

That explains it.


The technically preferred solution would be if you can somehow avoid calling those functions directly from the test code.

I have seen no way. Any idea? Something generic, that works on a lot of shapes?

  Less appealing
hacks to get it working are either to not mark those functions as SVX_DLLPRIVATE in include/svx/svdoashp.hxx,

Have there been special reasons to exclude these functions? They are public functions.

 or to make
svx/CppunitTest_svx_unit.mk use gb_CppunitTest_use_library_objects to directly include (copies of) the svxcore objects, instead of using gb_CppunitTest_use_libraries to link against the svxcore library.

Do you prefer one of the two "hacks" over the other?

Kind regards
Regina

_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice




[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux