Hey Gurung,
On Fri, Aug 24, 2018 at 6:35 PM Rahul Gurung <gurungrahul2@xxxxxxxxx> wrote:
Hey,I did the push, waiting to get it reviewed.
I just pushed a few fixes for the patch. You removed quite a few files from the makefile which later breaks the build. Additionally, you forgot a ; after CPPUNIT_TEST which caused some additional errors.
An unrelated thing that I would suggest for the future is to not push patches as drafts as only admins and the people added by you as reviewers will see the change. You miss all the helpful hands of the remaining LibreOffice developers if they can not see your patch :)
Regards,
Markus
Regards,GurungOn 22 August 2018 at 23:11, Markus Mohrhard <markus.mohrhard@xxxxxxxxxxxxxx> wrote:Hey Rahul,can you push your current state to gerrit so that we can discuss the code more easily?Regards,MarkusOn Wed, Aug 22, 2018 at 7:28 PM Rahul Gurung <gurungrahul2@xxxxxxxxx> wrote:_______________________________________________Hey,I was experimenting with cpp test by making a new test( transfered from java tests) and activating it when I run make test it threw this error, what can this error possibly mean, I know there can be many cases and this question may be unanswerable, but please help if possible./home/gurungrahul2/libreoffice/workdir/CxxObject/test/source/mtfxmldump.o: In function `MetafileXmlDump::dumpAndParse(GDIMetaFile const&, rtl::OUString const&)':
mtfxmldump.cxx:(.text+0x5868): undefined reference to `tools::XmlWriter::startDocument(int)'
/home/gurungrahul2/libreoffice/workdir/CxxObject/test/source/primitive2dxmldump.o: In function `Primitive2dXmlDump::dumpAndParse(drawinglayer::primitive2d::Primitive2DContainer const&, rtl::OUString const&)':
primitive2dxmldump.cxx:(.text+0x1608): undefined reference to `tools::XmlWriter::startDocument(int)'
/home/gurungrahul2/libreoffice/workdir/CxxObject/test/source/screenshot_test.o: In function `ScreenshotTest::setUp()':
screenshot_test.cxx:(.text+0x6a2): undefined reference to `test::Directories::getURLFromWorkdir(rtl::OUString const&) const'
/home/gurungrahul2/libreoffice/workdir/CxxObject/test/source/screenshot_test.o: In function `ScreenshotTest::implSaveScreenshot(BitmapEx const&, rtl::OString const&)':
screenshot_test.cxx:(.text+0xc68): undefined reference to `test::Directories::getURLFromWorkdir(rtl::OUString const&) const'
/home/gurungrahul2/libreoffice/workdir/CxxObject/test/source/screenshot_test.o: In function `ScreenshotTest::processDialogBatchFile(rtl::OUString const&)':
screenshot_test.cxx:(.text+0x2364): undefined reference to `test::Directories::getURLFromSrc(rtl::OUString const&) const'
collect2: error: ld returned 1 exit status
/home/gurungrahul2/libreoffice/solenv/gbuild/LinkTarget.mk:636: recipe for target '/home/gurungrahul2/libreoffice/workdir/LinkTarget/Library/libtest.so' failed
make[1]: *** [/home/gurungrahul2/libreoffice/workdir/LinkTarget/Library/libtest.so] Error 1
Makefile:120: recipe for target 'test' failed
make: *** [test] Error 2Thanks.
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice
_______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice
