Calc - Debugging issues in undo

[jrope@xxxxxxxxxxxx (Julien Ropé)]

 Â Hi,

 Â I am currently working on issue #118842 
(https://bugs.documentfoundation.org/show_bug.cgi?id=118842) and #39217 
(https://bugs.documentfoundation.org/show_bug.cgi?id=39217).

 Â Both are related to the copy of formatted text from a web browser, and 
then using "undo".

 Â The first issue is that rows' height are not restored with the undo.
 Â The other one is that images copied this way are not removed with the 
undo.

 Â I was able to work around the first by forcing a call to 
"AdjustRowHeight()" after the undo, but it doesn't address the root 
cause, so I'm not sure this can be called a fix.

 Â For the second, I think the image creation doesn't trigger the 
creation of an "undo action" at all - only the text is registered in the 
undo.
 Â I've tracked the image creation into the scfilt library 
(ScEEImport::InsertGraphic()), but it doesn't looks like the right place 
to manage undo actions. Now the caller (ScImportExport::HTML2Doc()) 
doesn't have a clue that a graphic has been created, so I'm not sure how 
it could handle the undo part...

 Â All in all, I think I lack some better understanding of how the undo 
management is performed in LibreOffice.
 Â Do you have any suggestion / documentation to help me troubleshoot this?


 Â Best regards,

 Â Julien