No, the patch dose not affect tc only dmesg/klogd ect. It changes printk's into HTB_DBG macros,
these macros don't print unless you set HTB into debug mode :)
The default kernel workes ?great? with my script 2.4.x and 2.5.x.
Here is an example...
The script workes like so... (10: is the qdisc-id)
filbert:~# /etc/network/mrtg.overlimits.pl 10: total,over
96320 <-- This is the total.
6630 <-- These are the overlimits (the total,over param dose this)
filbert:~# /etc/network/mrtg.overlimits.pl 10: total,over
96336
6654
filbert:~# /etc/network/mrtg.overlimits.pl 10: total,over
96359
6683
filbert:~# /etc/network/mrtg.overlimits.pl 10: total,over
96373
6705
mrtg.cfg lookes like this.
#############################################################
#
#
Target[toverlimits]: `/etc/network/mrtg.overlimits.pl 10: total,over`
MaxBytes[toverlimits]: 6400
AbsMax[toverlimits]: 640000
WithPeak[toverlimits]: wmy
Options[toverlimits]: noinfo, perminute
YLegend[toverlimits]: Packets/Minute
ShortLegend[toverlimits]: p/min
Legend1[toverlimits]: Sent Traffic in Packets per Minute
Legend2[toverlimits]: Overlimit Traffic in Packets per Minute
Legend3[toverlimits]: Maximal 5 Minute Sent Traffic
Legend4[toverlimits]: Maximal 5 Minute Overlimit Traffic
LegendI[toverlimits]: Sent:
LegendO[toverlimits]: Overlimit:
Title[toverlimits]: Root Qdisc Sent/Overlimits on Internet Pipe -- Filbert
PageTop[toverlimits]: <H1>Root Qdisc Sent/Overlimits on Internet Pipe -- Filbert</H1>
<TABLE>
<TR><TD>System:</TD> <TD>Filbert (Main Router and Moms PC)</TD></TR>
<TR><TD>Maintainer:</TD> <TD>Cheako cheako911@xxxxxxxxx</TD></TR>
<TR><TD>Description:</TD><TD>Sent/Overlimits on Internet Pipe</TD></TR>
</TABLE>
#-------------------------------------------------------------------
You can see my graphs at http://filbert.is-a-geek.org/mrtg/
P.N. The original patch I sent in had one bug, theres a part that lookes like this "q->debug>>(0)
|= 3;"
It needed to look like this. "debug_backup = q->debug;"
@@ -1046,7 +1047,10 @@
if (min_delay == LONG_MAX) {
printk(KERN_ERR "HTB: dequeue bug (%d,%lu,%lu), report it please !\n",
evs_used,q->jiffies,jiffies);
+ debug_backup = q->debug;
+ q->debug |= 3>>(0);
htb_debug_dump(q);
+ q->debug = debug_backup;
} else
printk(KERN_WARNING "HTB: mindelay=%ld, some class has "
"too small rate\n",min_delay);
--- Trevor Warren <trevorwarren@xxxxxxxxxxxx> wrote:
> Sorry Mike,
>
> This isn't an answer to your queries but instead a question. I would
> like to know if there are any added fields to the tc -s -d output post
> application of the 2.5 kernel patch you have applied below.
>
> Cause i am using htb with 2.4.21 and there isn't much of graphing i can
> do with the same. Especially no current rate parameter for HTB sub
> classes.
>
> Trevor
>
>
> On Sat, 2003-07-05 at 03:09, Mike Mestnik wrote:
> > I use MRTG to graph tc -d output, so the debug_dump fills up my dmesg logs ect. It's just
> > annoying.
> >
> > Attached is a patch vs 2.5.74 and my MRTG script.
> >
> > __________________________________
> > Do you Yahoo!?
> > SBC Yahoo! DSL - Now only $29.95 per month!
> > http://sbc.yahoo.com
> --
> ( >- LINUX, It's all about CHOICE -< )
> /~\ __ twarren@xxxxxxxxxx __ /~\
> | \) / Pre Sales Consultant - Red Hat \ (/ |
> |_|_ \ 9820349221(M) | 22881326(O) / _|_|
> \___________________________________/
>
__________________________________
Do you Yahoo!?
SBC Yahoo! DSL - Now only $29.95 per month!
http://sbc.yahoo.com
