Re: nested_free_all_saved_vmcss freeing vmx->vmcs01?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-01-03 20:02, Marcelo Tosatti wrote:
> 
> Am i missing something, or should nested_free_all_saved_vmcss not
> call 
> 
>         if (vmx->loaded_vmcs != &vmx->vmcs01)
>                 free_loaded_vmcs(&vmx->vmcs01);
> 
> ?

This is relevant if we call nested_free_all_saved_vmcss on cleanup while
L2 was still active. In this case, the
free_loaded_vmcs(vmx->loaded_vmcs) will free the item's loaded_vmcs we
skipped earlier in that function - OK, and now I also understand your patch.

Jan


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux