On Thu, Jan 02, 2014 at 11:17:51AM -0800, Christoffer Dall wrote: > On Thu, Jan 02, 2014 at 07:50:27PM +0100, Andrew Jones wrote: > > On Thu, Jan 02, 2014 at 09:44:39AM -0800, Christoffer Dall wrote: > > > > My cross-compiler was generating broken code with anything less. I > > > > haven't checked later compilers yet to see if it's fixed or not. > > > > > > > > > > which GCC version? > > > > $ arm-linux-gnu-gcc -v > > Using built-in specs. > > COLLECT_GCC=arm-linux-gnu-gcc > > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/arm-linux-gnueabi/4.8.1/lto-wrapper > > Target: arm-linux-gnueabi > > Configured with: ../gcc-4.8.1-20130717/configure --bindir=/usr/bin > > --build=x86_64-redhat-linux-gnu --datadir=/usr/share > > --disable-decimal-float --disable-dependency-tracking --disable-gold > > --disable-libgomp --disable-libmudflap --disable-libquadmath > > --disable-libssp --disable-nls --disable-plugin --disable-shared > > --disable-silent-rules --disable-sjlj-exceptions --disable-threads > > --enable-checking= --enable-gnu-unique-object --enable-initfini-array > > --enable-languages=c --enable-linker-build-id --enable-nls > > --enable-obsolete --enable-targets=all --exec-prefix=/usr > > --host=x86_64-redhat-linux-gnu --includedir=/usr/include > > --infodir=/usr/share/info --libexecdir=/usr/libexec --localstatedir=/var > > --mandir=/usr/share/man --prefix=/usr --program-prefix=arm-linux-gnu- > > --sbindir=/usr/sbin --sharedstatedir=/var/lib --sysconfdir=/etc > > --target=arm-linux-gnueabi > > --with-bugurl=http://bugzilla.redhat.com/bugzilla/ > > --with-linker-hash-style=gnu --with-newlib --with-system-libunwind > > --with-system-zlib --without-headers > > --with-isl=/builddir/build/BUILD/gcc-4.8.1-20130717/isl-install > > --with-cloog=/builddir/build/BUILD/gcc-4.8.1-20130717/cloog-install > > Thread model: single > > gcc version 4.8.1 20130717 (Red Hat 4.8.1-5) (GCC) > > > > > > > I was expecting to see a __raw_... IO accessor definitions for ARM here, > > > > > specifically so we avoid the register-writeback versions that are not > > > > > supported on ARM. > > > > > > > > > > See arch/arm/include/asm/io.h in the kernel. > > > > > > > > k, I'll grab them, but they'll go in lib/arm/io.h. I think I'll drop > > > > these lib/test_util.* in v3, so far they're fairly useless cruft. We > > > > can bring them back if they have enough purpose later. > > > > > > > > > > I already did that for my WIP, see commit > > > 680054064db4dd710991f064a88a12012944d376 in: > > > > > > https://github.com/columbia/kvm-unit-tests.git > > > > I'll fetch your tree and start going through it tomorrow. Thanks for > > jumping in!! > > > Sure, if you fix anything in your existing series, I'll be happy to > rebase my patches and take a pass at squashing some of them and such so > we can get them out as an RFC. Lot's of good stuff in there. I also had a start on the psci/smp stuff (in the form of notes, not code) before the holiday break, so I might have some more suggestions there once we get the patches rebased and cleaned up. I'd like to get a v3 posted [and committed] of this series, a version that uses libfdt, before we get too far along, allowing us to build on a clean base. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html