On 05.11.2013, at 18:22, Cédric Le Goater <clg@xxxxxxxxxx> wrote:
> They will be used to decide whether to byte-swap or not. When Little
> Endian host kernels come, these routines will need to be changed
> accordingly.
>
> Signed-off-by: Cédric Le Goater <clg@xxxxxxxxxx>
> ---
> arch/powerpc/include/asm/kvm_book3s.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/kvm_book3s.h b/arch/powerpc/include/asm/kvm_book3s.h
> index d11c089..22ec875 100644
> --- a/arch/powerpc/include/asm/kvm_book3s.h
> +++ b/arch/powerpc/include/asm/kvm_book3s.h
> @@ -270,6 +270,16 @@ static inline ulong kvmppc_get_pc(struct kvm_vcpu *vcpu)
> return vcpu->arch.pc;
> }
>
> +static inline bool kvmppc_need_byteswap(struct kvm_vcpu *vcpu)
> +{
> + return vcpu->arch.shared->msr & MSR_LE;
> +}
> +
> +static inline bool kvmppc_is_bigendian(struct kvm_vcpu *vcpu)
> +{
> + return !kvmppc_need_byteswap(vcpu);
This is logically reversed. kvmppc_need_byteswap should check kvmppc_is_bigendian(), not the other way around.
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
