Re: [v5][PATCH] KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.11.2013, at 03:01, “tiejun.chen” <tiejun.chen@xxxxxxxxxxxxx> wrote:

> Alex,
> 
> I suppose Scott already elaborate anything you want to know.

Thanks, applied with this minor patch on top:

diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index 191c32b..be3de1d 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -470,7 +470,7 @@ _GLOBAL(kvmppc_resume_host)
 #ifdef CONFIG_64BIT
        /*
         * We enter with interrupts disabled in hardware, but
-        * we need to call RECONCILE_IRQ_STATE anyway to ensure
+        * we need to call RECONCILE_IRQ_STATE to ensure
         * that the software state is kept in sync.
         */
        RECONCILE_IRQ_STATE(r3,r5)

I've also taken the liberty of making the patch description be more verbose:

KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

Rather than calling hard_irq_disable() when we're back in C code
we can just call RECONCILE_IRQ_STATE to soft disable IRQs while
we're already in hard disabled state.

This should be functionally equivalent to the code before, but
cleaner and faster.

Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>
[agraf: fix comment, commit message]
Signed-off-by: Alexander Graf <agraf@xxxxxxx>


Thanks, applied to kvm-ppc-queue.

Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux