On Sun, Dec 1, 2013 at 1:09 PM, Kim Phillips <kim.phillips@xxxxxxxxxx> wrote: > > On Mon, 30 Sep 2013 17:28:36 +0200 > Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > > This is a preview of the base work, towards VFIO support on ARM platforms > > with an IOMMU. It forms a base on to which to implement the functionality > > necessary to enable using device tree devices on ARM (and other platforms > > based on device trees) with VFIO. > > > > This patch series has been subjected to limited testing on the Arndale board > > (with the Exynos 5250 System MMU). More extensive testing will follow as more > > features are implemented. > > Hi, I'm trying to attach the vfio-platform driver to an(y) iommu-backed > device on the arndale. I chose the relatively simple 'tv' device, > isolated it in the arndale device tree (to get rid of any dependency > conflicts), and, when I run Alex' vfio-correctness-tests [1], I get > this: > > # echo 14650000.sysmmu > /sys/bus/platform/devices/14650000.sysmmu/driver/unbind > # echo 14650000.sysmmu > /sys/bus/platform/drivers/vfio-platform/bind > # ls -l /sys/bus/platform/devices/14650000.sysmmu/iommu_group > lrwxrwxrwx 1 root root 0 Oct 1 23:14 /sys/bus/platform/devices/14650000.sysmmu/iommu_group -> ../../kernel/iommu_groups/43 > # vfio-tests/vfio-correctness-tests 43 > [ 84.567643] ------------[ cut here ]------------ > [ 84.572258] WARNING: CPU: 0 PID: 1606 at drivers/iommu/exynos-iommu.c:472 __exynos_sysmmu_enable+0x170/0x184() > [ 84.582225] Modules linked in: > [ 84.585268] CPU: 0 PID: 1606 Comm: vfio-correctnes Not tainted 3.13.0-rc1-00296-gb703d74-dirty #46 > [ 84.594219] [<c0014d20>] (unwind_backtrace+0x0/0xf4) from [<c0011648>] (show_stack+0x10/0x14) > [ 84.602719] [<c0011648>] (show_stack+0x10/0x14) from [<c0377948>] (dump_stack+0x7c/0xb0) > [ 84.610791] [<c0377948>] (dump_stack+0x7c/0xb0) from [<c001dc50>] (warn_slowpath_common+0x6c/0x88) > [ 84.619730] [<c001dc50>] (warn_slowpath_common+0x6c/0x88) from [<c001dd08>] (warn_slowpath_null+0x1c/0x24) > [ 84.629365] [<c001dd08>] (warn_slowpath_null+0x1c/0x24) from [<c02dace8>] (__exynos_sysmmu_enable+0x170/0x184) > [ 84.639348] [<c02dace8>] (__exynos_sysmmu_enable+0x170/0x184) from [<c02dad4c>] (exynos_iommu_attach_device+0x50/0x108) > [ 84.650111] [<c02dad4c>] (exynos_iommu_attach_device+0x50/0x108) from [<c02d939c>] (iommu_attach_device+0x64/0xb8) > [ 84.660440] [<c02d939c>] (iommu_attach_device+0x64/0xb8) from [<c02d92ec>] (iommu_group_for_each_dev+0x78/0x94) > [ 84.670509] [<c02d92ec>] (iommu_group_for_each_dev+0x78/0x94) from [<c0263678>] (vfio_iommu_type1_attach_group+0xd0/0x144) > [ 84.681530] [<c0263678>] (vfio_iommu_type1_attach_group+0xd0/0x144) from [<c02629e0>] (vfio_fops_unl_ioctl+0x3ac/0x460) > [ 84.692295] [<c02629e0>] (vfio_fops_unl_ioctl+0x3ac/0x460) from [<c00c1f14>] (do_vfs_ioctl+0x3f0/0x5b8) > [ 84.701668] [<c00c1f14>] (do_vfs_ioctl+0x3f0/0x5b8) from [<c00c2114>] (SyS_ioctl+0x38/0x60) > [ 84.710002] [<c00c2114>] (SyS_ioctl+0x38/0x60) from [<c000e1a0>] (ret_fast_syscall+0x0/0x30) > [ 84.718417] ---[ end trace a1400d7981f699ce ]--- > [ 84.723071] vfio-platform 14650000.sysmmu: exynos_iommu_attach_device: Failed to attach IOMMU with pgtable 0x6eae8000 > > It's failing this test: > > if (WARN_ON(!client)) > return -ENODEV; > > but I haven't been able to figure out why...I have the exynos > iommu v10 patchseries applied, and even though there's not much > documentation available for this device, I figure this simple test is > supposed to 'just work.' Any ideas? > Hello Kim, Thanks for your interest on our VFIO work. VFIO for platform is still under development, and cannot be used yet to fully assign a device. However, looking at the example you ran, I would not have expected it to fail so spectacularly, so this is definitely something I will investigate for our next update to the patch series. Thanks for pointing this out. I plan to release an updated series with several improvements and fixes soon enough. Best regards, Antonios > > Thanks, > > Kim > > [1] git://github.com/awilliam/tests.git -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
