On Wed, Oct 30, 2013 at 04:46:28PM +0100, Paolo Bonzini wrote: > Il 30/10/2013 16:39, Raghavendra K T ha scritto: > >> > >> Why even error out at all here? You should never care about debugfs > >> file creation return values, so why pass any error back up the stack? > > > > We could change this to return 0, but we will still be left with > > kvm_main.c: kvm_init_debug() function which creates the kvm debugfs > > directory. (I thought Paolo and Gleb's ack would be needed for > > that change since it would be a bigger decision for me) > > > > So I just made the patch to fix only Linus's concern. > > Even if it is okay to exit and not create the files (and I think it's a > bit surprising), I'd like at least a printk to signal what's happening. > But there should be no reason for debugfs directory creation to fail in > the end, except for basic mistakes such as the one that Tim reported, so > I think it's better to report the failure. Creation will "fail" if debugfs is not enabled, so spiting out printk messages in that case is not a good idea. greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
