On Thu, Oct 17, 2013 at 12:01:52PM -0700, Christoffer Dall wrote: > On Thu, Oct 17, 2013 at 11:35:09AM +0200, Andrew Jones wrote: > > On Wed, Oct 16, 2013 at 06:06:06PM -0700, Christoffer Dall wrote: > > > > -The exit status of the binary (and the script) is inconsistent: with > > > > -qemu-system, after the unittest is done, the exit status of qemu is 1, > > > > -different from the 'old style' qemu-kvm, whose exit status in successful > > > > -completion is 0. > > > > +To create the tests' images do > > > > > > tests' images doesn't read very nice, can we just say test images? > > > > OK > > > > > > > > > + ./configure > > > > + make > > > > +in this directory. Tests' images are created in ./<ARCH>/*.flat > > > > + > > > > +Then use the runner script to detect the correct invocation and > > > > +invoke the test, e.g. > > > > + ./x86-run ./x86/msr.flat > > > > +or > > > > + ./run_tests.sh > > > > +to run them all. > > > > > > While you're at it, it would be great to provide a little more context > > > in the README file. > > > > > > For example, we start talking abouter 'runner scripts', we refer to > > > something called '.flat', and we refer to QEMU without explaining how > > > this whole thing works, what the components are, what is required of > > > QEMU etc. > > > > > > I think that would be useful for the wider adoption of kvm-unit-tests to > > > developers writing ad-hoc patches for KVM. > > > > > > A reference to docs/testdev.txt from somewhere approrpriate in such text > > > would probably also be useful... > > > > > > I know much of this is arch-specific, but there must be something > > > generic or common across the architecture, and that would in essense be > > > capturing what 'kvm-unit-tests' give you, which I think is very useful > > > to have in the readme. > > > > > > > Agreed. I'll see what I can do with the overall documentation. And I need > > to create an arm/README for arm specific documentation as well. > > > We can work on this a bit together as well if you want, I need to get a > slightly broader understanding of this framework first though. Are you > going to be at KVM forum? > Yup. Already here :-) drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
