Re: [PATCH 2/3] kvm/ppc: IRQ disabling cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-09-06 at 01:06 +0200, Alexander Graf wrote:
> On 06.09.2013, at 00:09, Scott Wood wrote:
> 
> > On Thu, 2013-07-11 at 01:09 +0200, Alexander Graf wrote:
> >> On 11.07.2013, at 01:08, Scott Wood wrote:
> >> 
> >>> On 07/10/2013 06:04:53 PM, Alexander Graf wrote:
> >>>> On 11.07.2013, at 01:01, Benjamin Herrenschmidt wrote:
> >>>>> On Thu, 2013-07-11 at 00:57 +0200, Alexander Graf wrote:
> >>>>>>> #ifdef CONFIG_PPC64
> >>>>>>> +     /*
> >>>>>>> +      * To avoid races, the caller must have gone directly from having
> >>>>>>> +      * interrupts fully-enabled to hard-disabled.
> >>>>>>> +      */
> >>>>>>> +     WARN_ON(local_paca->irq_happened != PACA_IRQ_HARD_DIS);
> >>>>>> 
> >>>>>> WARN_ON(lazy_irq_pending()); ?
> >>>>> 
> >>>>> Different semantics. What you propose will not catch irq_happened == 0 :-)
> >>>> Right, but we only ever reach here after hard_irq_disable() I think.
> >>> 
> >>> And the WARN_ON helps us ensure that it stays that way.
> >> 
> >> Heh - ok :). Works for me.
> > 
> > What's the status on this patch?
> 
> IIUC it was ok. Ben, could you please verify?

ping

-Scott



--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux