Re: [PATCH 2/7] KVM: mmu: remove uninteresting MMU "new_cr3" callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 03/10/2013 12:23, Gleb Natapov ha scritto:
>> > The commit message mentioned that "mmu_free_roots() is somewhat of an overkill,
>> > but fixing that is more complicated and will be done after this minimal fix".
>> > One year has passed, and no one really felt the need to do a different fix.
>> > Wrap the call with a kvm_mmu_new_cr3 function for clarity, but remove the
>> > callback.
>> > 
> Well the reason for it is because whoever knew about the problem found
> other things to do meanwhile :) But do we really need something smarter
> here anyway? The situation described in e676505 should be extremely rare
> even on non unrestricted guest HW and it happens during slow emulation
> anyway, so optimization will likely not be noticeable.

Yeah, and it's not like code that runs without paging will move to cr3
in a hot loop. :)

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux