On Wed, 2013-10-02 at 18:53 +0200, Alexander Graf wrote: > On 02.10.2013, at 18:40, Scott Wood wrote: > > > On Wed, 2013-10-02 at 16:19 +0200, Alexander Graf wrote: > >> On 23.09.2013, at 07:23, Bharat Bhushan wrote: > >>> static inline long kvm_hypercall0_1(unsigned int nr, unsigned long *r2) > >>> @@ -65,7 +54,7 @@ static inline long kvm_hypercall0_1(unsigned int nr, unsigned long *r2) > >>> unsigned long out[8]; > >>> unsigned long r; > >>> > >>> - r = kvm_hypercall(in, out, KVM_HCALL_TOKEN(nr)); > >>> + r = epapr_hypercall(in, out, KVM_HCALL_TOKEN(nr)); > >> > >> Won't this break when CONFIG_EPAPR_PARAVIRT=n? We wouldn't have epapr_hcalls.S compiled into the code base then and the bl above would reference an unknown function. > > > > KVM_GUEST selects EPAPR_PARAVIRT. > > But you can not select KVM_GUEST and still call these inline functions, no? No. > Like kvm_arch_para_features(). Where does that get called without KVM_GUEST? How would that work currently, with the call to kvm_hypercall() in arch/powerpc/kernel/kvm.c (which calls epapr_hypercall, BTW)? -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
