Re: [PATCH v4] KVM: nVMX: Fully support of nested VMX preemption timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 14, 2013 at 3:44 PM, Jan Kiszka <jan.kiszka@xxxxxx> wrote:
> On 2013-09-13 19:15, Paolo Bonzini wrote:
>> Il 06/09/2013 04:04, Arthur Chunqi Li ha scritto:
>>> +    preempt_val_l1 = delta_tsc_l1 >> preempt_scale;
>>> +    if (preempt_val_l2 <= preempt_val_l1)
>>> +            preempt_val_l2 = 0;
>>> +    else
>>> +            preempt_val_l2 -= preempt_val_l1;
>>> +    vmcs_write32(VMX_PREEMPTION_TIMER_VALUE, preempt_val_l2);
>>
>> Did you test that a value of 0 triggers an immediate exit, rather than
>> counting down by 2^32?  Perhaps it's safer to limit the value to 1
>> instead of 0.
>
> To my experience, 0 triggers immediate exists when the preemption timer
> is enabled.
Yes, L2 VM will exit immediately when the value is 0 with my patch.

Arthur
>
> Jan
>
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux