Re: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 7, 2013 at 11:46 AM, Michael Ellerman
<michael@xxxxxxxxxxxxxx> wrote:
> On powerpc we build kvmtool as a 64bit binary. We do that by setting
> -m64 in our CFLAGS. For most things we just call $(CC) and it passes
> that info onto the linker.
>
> However there is one place where we explicitly call the linker, in the
> build of guest/init - and in that case we need to tell the linker to
> build 64bit.
>
> We have gotten away with this so far because we have been building with
> a 64bit only toolchain. However if you build with a biarch toolchain,
> which generally defaults to 32bit, we fail to link.
>
> The fix is to defined LDFLAGS appropriately and pass it to LD.
>
> Tested on powerpc and x86-64.
>
> Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux