在 2013-8-5,2:08,Jan Kiszka <jan.kiszka@xxxxxx> 写道: > On 2013-08-04 20:04, Arthur Chunqi Li wrote: >> @@ -432,6 +432,22 @@ enum Ctrl1 { >> #define HYPERCALL_MASK 0xFFF >> #define HYPERCALL_VMEXIT 0x1 >> >> + >> +extern u64 hypercall_field; >> +extern u32 vpid_cnt; >> +extern ulong fix_cr0_set, fix_cr0_clr; >> +extern ulong fix_cr4_set, fix_cr4_clr; >> +extern struct regs regs; >> +extern struct vmx_test *current; >> +extern bool launched; > > You didn't address my question if we need them all to write test cases > or if some are actually core internal. You are right. Not all global variants in last version is necessary for test cases, so I move some of them to vmx.c internal. The rest ones in this version are needed by tests to identify some states. Arthur. > > The rest looks good. > > Jan > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html