Re: [PATCH v3] kvm-unit-tests : Basic architecture of VMX nested test case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 30, 2013 at 10:53 PM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> Il 28/07/2013 16:00, Arthur Chunqi Li ha scritto:
>> +
>> +     while (1) {
>> +             asm volatile (
>> +                     "mov %%rsp, %%rsi\n\t"
>> +                     "mov %2, %%rdi\n\t"
>> +                     "vmwrite %%rsi, %%rdi\n\t"
>> +
>> +                     LOAD_GPR_C
>> +                     "cmpl $0, %1\n\t"
>> +                     "jne 1f\n\t"
>> +                     LOAD_RFLAGS
>> +                     "vmlaunch\n\t"
>> +                     "jmp 2f\n\t"
>> +                     "1: "
>> +                     "vmresume\n\t"
>> +                     "2: "
>> +                     "setbe %0\n\t"
>
> Perhaps here add
>
>                         jbe vmx_return
>                         ud2
>
> but it can be added in a follow-up.
>
>> +                     "vmx_return:\n\t"
>> +                     SAVE_GPR_C
>> +                     SAVE_RFLAGS
>> +                     : "=m"(fail)
>> +                     : "m"(launched), "i"(HOST_RSP)
>> +                     : "rdi", "rsi", "memory", "cc"
>> +
>> +             );
>
> Nice! :)
>
> I pushed the patch.
Hi Paolo,
Slow down pushing it. There's something wrong with host_rflags
handling. I will commit another version as well as your suggestion,
you could push that version.

Thanks,
Arthur
>
> Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux