Hello Maintainers: Please help check the patch whether OK or not, when you have time. Thanks. On 07/22/2013 11:40 AM, Chen Gang wrote: > 'target' will be set to '-1' in kvm_arch_vcpu_init(), and it need check > 'target' whether less than zero or not in kvm_vcpu_initialized(). > > So need define target as 'int' instead of 'u32', just like ARM has done. > > > The related warning: > > arch/arm64/kvm/../../../arch/arm/kvm/arm.c:497:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > --- > arch/arm64/include/asm/kvm_host.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 644d739..0859a4d 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -129,7 +129,7 @@ struct kvm_vcpu_arch { > struct kvm_mmu_memory_cache mmu_page_cache; > > /* Target CPU and feature flags */ > - u32 target; > + int target; > DECLARE_BITMAP(features, KVM_VCPU_MAX_FEATURES); > > /* Detect first run of a vcpu */ > -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html