Il 29/07/2013 15:12, Gleb Natapov ha scritto: >> Il 25/07/2013 12:59, Gleb Natapov ha scritto: >>> > > + * we should use its exit controls. Note that IA32_MODE, LOAD_IA32_EFER >>> > > + * bits are further modified by vmx_set_efer() below. >> > >> > IA32E_MODE, but the last sentence is not relevant anyway for this >> > vmcs_write32; in fact, the next command basically duplicates it. >> > > IA32E_MODE is not relevant, it never changes in VM_EXIT_CONTROLS, but > LOAD_IA32_EFER refers to VM_EXIT_LOAD_IA32_EFER, which can be set by > vmx_set_efer() and is different from VM_ENTRY_LOAD_IA32_EFER that > comment bellow talks about. > Yes. Just fix the comment so that it is clear. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html