Re: [Qemu-devel] [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 08.07.2013 14:40, schrieb Igor Mammedov:
> On Mon,  8 Jul 2013 03:03:54 +0200
> Andreas Färber <afaerber@xxxxxxx> wrote:
> 
>> From: Igor Mammedov <imammedo@xxxxxxxxxx>
>>
>> - since hyperv_* helper functions are used only in target-i386/kvm.c
>>   move them there as static helpers
>>
>> Requested-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
>> Signed-off-by: Igor Mammedov <imammedo@xxxxxxxxxx>
>> Signed-off-by: Andreas Färber <afaerber@xxxxxxx>
> I'm not tested it yet, but it looks good to me.

Being from you originally and me having confidence in my changes on top,
I'm queuing this on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next

Andreas

>> ---
>>  v8 (imammedo) -> v9:
>>  * Use X86CPU instead of CPUX86State (only used in KVM)
>>  * Changed helper functions to X86CPU argument
>>  * Moved field initialization to QOM instance_init
>>  * Fixed subject (not today's "CPUState")
>>
>>  target-i386/Makefile.objs |  2 +-
>>  target-i386/cpu-qom.h     |  4 +++
>>  target-i386/cpu.c         | 16 ++++++++----
>>  target-i386/cpu.h         |  4 +++
>>  target-i386/hyperv.c      | 64 -----------------------------------------------
>>  target-i386/hyperv.h      | 45 ---------------------------------
>>  target-i386/kvm.c         | 36 ++++++++++++++++++--------
>>  7 files changed, 46 insertions(+), 125 deletions(-)
>>  delete mode 100644 target-i386/hyperv.c
>>  delete mode 100644 target-i386/hyperv.h

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux