On 07/13/2013 07:05 AM, Benjamin Herrenschmidt wrote:
On Fri, 2013-07-12 at 12:50 -0500, Scott Wood wrote:
[1] SOFT_DISABLE_INTS seems an odd name for something that updates the
software state to be consistent with interrupts being *hard* disabled.
I can sort of see the logic in it, but it's confusing when first
encountered. From the name it looks like all it would do is set
soft_enabled to 1.
It's indeed odd. Also worse when we use DISABLE_INTS which is just a
macro on top of SOFT_DISABLE_INTS :-)
I've been wanting to change the macro name for a while now and never
got to it. Patch welcome :-)
What about SOFT_IRQ_DISABLE? This is close to name hard_irq_disable() :) And
then remove all DISABLE_INTS as well?
Tiejun
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
