On Thu, 2013-07-11 at 11:18 -0500, Scott Wood wrote: > > If we set IRQs as soft-disabled prior to calling hard_irq_disable(), > then hard_irq_disable() will fail to call trace_hardirqs_off(). Sure because setting them as soft-disabled will have done it. However by doing so, you also create the possibility of latching a new event in irq_happened. > > or by disabling preemption until we enter the guest for real. > > I don't follow this one. We're exiting, not entering. > > > Any preferences? > > Use arch_local_save_flags() in hard_irq_disable() instead of reading > soft_enabled with C code. That or just use local_paca... Though we'd had problems in the past where gcc would defeat us there and essentially copy r13 to another register and start indexing from there. That kills you if you preempt. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
