Re: [PATCH] KVM: nVMX: Set segment infomation of L1 when L2 exits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 11, 2013 at 5:43 PM, Gleb Natapov <gleb@xxxxxxxxxx> wrote:
> On Thu, Jul 11, 2013 at 05:06:04PM +0800, Arthur Chunqi Li wrote:
>> When L2 exits to L1, segment infomations of L1 are not set correctly.
>> According to Intel SDM 27.5.2(Loading Host Segment and Descriptor
>> Table Registers), segment base/limit/access right of L1 should be
>> set to some designed value when L2 exits to L1. This patch fixes
>> this.
>>
> Does this fix your test case?
Besides this bug, there are also some bugs in my test case. Now all
things run well.
>
>> Signed-off-by: Arthur Chunqi Li <yzt356@xxxxxxxxx>
>> ---
>>  arch/x86/kvm/vmx.c |   26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 1200e4e..3cf702b 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -8028,6 +8028,32 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu,
>>       vmcs_write16(GUEST_GS_SELECTOR, vmcs12->host_gs_selector);
>>       vmcs_write16(GUEST_TR_SELECTOR, vmcs12->host_tr_selector);
>>
>> +     /* Set L1 segment info according to Intel SDM
>> +         27.5.2 Loading Host Segment and Descriptor-Table Registers */
>> +     vmcs_writel(GUEST_CS_BASE, 0x0);
>> +     vmcs_writel(GUEST_SS_BASE, 0x0);
>> +     vmcs_writel(GUEST_DS_BASE, 0x0);
>> +     vmcs_writel(GUEST_ES_BASE, 0x0);
>> +     vmcs_write32(GUEST_CS_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_SS_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_DS_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_ES_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_FS_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_GS_LIMIT, 0xFFFFFFFF);
>> +     vmcs_write32(GUEST_TR_LIMIT, 0x67);
>> +     vmcs_write32(GUEST_ES_AR_BYTES, 0xc093);
>> +     if (vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)
>> +             vmcs_write32(GUEST_CS_AR_BYTES, 0xa09b);
>> +     else
>> +             vmcs_write32(GUEST_CS_AR_BYTES, 0xc09b);
>> +     vmcs_write32(GUEST_SS_AR_BYTES, 0xc093);
>> +     vmcs_write32(GUEST_DS_AR_BYTES, 0xc093);
>> +     vmcs_write32(GUEST_FS_AR_BYTES, 0xc093);
>> +     vmcs_write32(GUEST_GS_AR_BYTES, 0xc093);
>> +     vmcs_write32(GUEST_TR_AR_BYTES, 0x8b);
> Please use AR_ defines for AR_BYTES fields (AR_S_MASK etc).
>
>> +     vmcs_writel(GUEST_RFLAGS, 0x2);
>> +
>> +
>>       if (vmcs12->vm_exit_controls & VM_EXIT_LOAD_IA32_PAT)
>>               vmcs_write64(GUEST_IA32_PAT, vmcs12->host_ia32_pat);
>>       if (vmcs12->vm_exit_controls & VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL)
>> --
>> 1.7.9.5
>
> --
>                         Gleb.



--
Arthur Chunqi Li
Department of Computer Science
School of EECS
Peking University
Beijing, China
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux