Re: [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/08/2013 01:58 PM, Will Deacon wrote:
Hi guys,

On Mon, Jul 08, 2013 at 09:12:26AM +0100, Pekka Enberg wrote:
On Sun, Jul 7, 2013 at 7:00 PM, Sasha Levin <sasha.levin@xxxxxxxxxx> wrote:
Commit "kvm tools: virtio: remove hardcoded assumptions
about guest page size" has introduced a bug that prevented
guests with more than 4gb of ram from booting.

The issue is that 'pfn' is a 32bit integer, so when multiplying
it by page size to get the actual page will cause an overflow if
the pfn referred to a memory area above 4gb.

Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>

Will, Michael, Asias, good to merge?

I'm at a conference at the moment, so unable to test this patch, but it
looks simple and correct enough to me:

   Acked-by: Will Deacon <will.deacon@xxxxxxx>

Applied, thanks a lot!

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux