On Wed, Jul 03, 2013 at 11:08:18AM +0200, Paolo Bonzini wrote: > Il 03/07/2013 11:05, Gleb Natapov ha scritto: > >>> Yes, the actual operation would be the same as this patch. You can > >>> rename kvm_mmu_invalidate_mmio_sptes to kvm_arch_memslots_installed, or > >>> something like that. But it would have to touch all architectures. > >> > >> I tried to avoid introducing x86-centric code into the generic one. > >> > >> If another arch can gain something by such function, I'm willing to > >> touch all arch code. > >> > > Please do. X86 is the most optimized one so it does things other arches > > do not yet. Slot generation update hook sounds generic enough. > > Yes, makes sense. However, this patch is still an improvement because > the current code is too easily mistaken for an off-by-one bug. > > Any improvements to the API can go on top. > If Takuya will send the proper fix shortly I do not see any reason to apply this one. It does not fix any bug. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
