> -----Original Message----- > From: kvm-owner@xxxxxxxxxxxxxxx [mailto:kvm-owner@xxxxxxxxxxxxxxx] > On Behalf Of Gleb Natapov > Sent: Monday, June 24, 2013 4:03 PM > To: Ren, Yongjie > Cc: kvm@xxxxxxxxxxxxxxx; pbonzini@xxxxxxxxxx > Subject: Re: [PATCH kvm-unit-tests 1/3] x86-run: correct a typo > 'qemsystem' -> 'qemusystem' > > On Mon, Jun 24, 2013 at 06:10:59AM +0000, Ren, Yongjie wrote: > > x86-run: correct a typo 'qemsystem' -> 'qemusystem' > > Before this fix, you should always get error info as below when running > 'x86-run' script. > > "QEMU binary has no support for test device. Exiting." > > > Patch is whitespace damaged. > Sorry, I'll correct it and resend my patches. > > Signed-off-by: Yongjie Ren <yongjie.ren@xxxxxxxxx> > > --- > > x86-run | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/x86-run b/x86-run > > index 2cf1f38..9526a0b 100755 > > --- a/x86-run > > +++ b/x86-run > > @@ -8,7 +8,7 @@ then > > qemu="${qemukvm}" > > else > > if > > - ${qemsystem} -device '?' 2>&1 | fgrep -e \"testdev\" > -e \"pc-testdev\" > /dev/null; > > + ${qemusystem} -device '?' 2>&1 | fgrep -e > \"testdev\" -e \"pc-testdev\" > /dev/null; > While you are at is lets replace fgrep invocation, which is deprecated, > with grep -F. > Yeah, I also found this issue and want to use 'grep -F' instead. I'll send another patch replace 'fgrep' with 'grep -F'. > > then > > qemu="${qemusystem}" > > else > > -- > > 1.7.9.5 > > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
