On 06/05/2013 02:29:47 AM, Caraman Mihai Claudiu-B02008 wrote:
> > case BOOKE_INTERRUPT_SPE_FP_ROUND:
> > +#ifdef CONFIG_SPE
> > kvmppc_booke_queue_irqprio(vcpu,
> > BOOKE_IRQPRIO_SPE_FP_ROUND);
> > r = RESUME_GUEST;
> > break;
>
> Why not use kvmppc_supports_spe() here, for consistency?
I added cpu_has_feature(CPU_FTR_SPE) for the case specified above,
but here
SPE_FP_ROUND is not shared with ALTIVEC. CONFIG_SPE is used in other
places
in KVM without this check, shouldn't be all or nothing?
I'd rather it be consistent, at least between handling one exception
and another.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
