Il 04/06/2013 14:53, Gleb Natapov ha scritto:
>> >
> Yeah. What about:
> if ((dr6 = guest_debug()))
> return handle_gues_debug();
> else if ((dr6 = check_bp()))
> return handle_bp(dr6);
I'll try either this...
>>>> > >> If you do not want EMULATE_PROCEED, I can just use -1 instead in
>>>> > >> kvm_vcpu_check_breakpoint, and return if r < 0.
>>>> > >>
>>> > > But you need to know what to return EMULATE_DONE or EMULATE_USER_EXIT.
>> >
>> > Sorry, _not_ return if r < 0.
>> >
> Function that returns enum or -1? This is worse IMO. Return
> EMULATE_DONE/EMULATE_USER_EXIT via a pointer will be better.
... or this, and see what looks nicer. But I like
if (check_bp(&r))
return r;
Thanks for the review.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
