On Wed, May 29, 2013 at 04:32:31PM +0200, Paolo Bonzini wrote: > Il 29/05/2013 16:30, Michael S. Tsirkin ha scritto: > >> > There are other responses in the thread here and I don't really care to > >> > bikeshed on this issue. > > Great. Let's make the bikeshed blue then? > > Yes, let's make it blue, but please promise to check into Peter's > register API so we can remove the case offsetof. I think it's overkill here. virtio was designed to be easy to implement with a simple switch statement. > I checked that it works on RHEL5, which is 4.1 and probably the oldest > compiler we care about (any other 4.1 lacks the __sync builtins; > upstream added them in 4.2). > > Paolo Are you sure? Documentation says 4.0 ... -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html