On Mon, May 20, 2013 at 05:17:31PM +0100, Marc Zyngier wrote:
> On 20/05/13 16:57, Catalin Marinas wrote:
> > On Tue, May 14, 2013 at 03:13:35PM +0100, Marc Zyngier wrote:
> >> +static inline bool kvm_is_write_fault(unsigned long esr)
> >> +{
> >> + unsigned long esr_ec = esr >> ESR_EL2_EC_SHIFT;
> >
> > Not that it would make much difference but for consistency - we use esr
> > as an 'unsigned int' in the arm64 code (only 32-bit needed).
>
> Indeed. Changing it would require a 32bit patch though, as I'd like to
> keep the two code bases in line.
>
> If you don't mind, I'll queue a patch changing this to "unsigned int" on
> both architectures once this is merged.
I'm OK if you push the patch afterwards, you can add my reviewed-by on
this patch.
Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
