Il 19/05/2013 08:37, Vadim Rozenfeld ha scritto: > On Thu, 2013-05-16 at 16:45 +0200, Paolo Bonzini wrote: >> Il 16/05/2013 16:26, Vadim Rozenfeld ha scritto: >>>>>>>>>>> >>>>>>>>>>> Yes, I have this check added in the second patch. >>>>>>>>>>> >>>>>>>>> Move it here please. >>>>>>> OK, will do it. >>>>> >>>>> Or better, remove all the handling of HV_X64_MSR_REFERENCE_TSC from this >>>>> patch, and leave it all to the second. >>>>> >>> What for? Could you please elaborate? > > To make code reviewable. Add one MSR here, the other in the second patch. > removing HV_X64_MSR_REFERENCE_TSC will make this particular patch > completely non-functional. Do you mean Windows guest will BSOD or just that they won't use the reference TSC? If the latter, it's not a problem. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html