"Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> writes: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: >> Asias He <asias@xxxxxxxxxx> writes: >> > scsi.c includes vhost.c which uses memcpy_fromiovec. >> > >> > This patch fixes this build failure. >> > >> > From Randy Dunlap: >> > ''' >> > on x86_64: >> > >> > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined! >> > >> > It needs to depend on NET since net/core/ provides that function. >> > ''' >> >> Proper fix please. >> >> Though I can't see why you thought this was a good idea. Nonetheless, I >> shan't highlight why: I have far too much respect for your intellects >> and abilities. >> >> No, don't thank me! > > Hi Rusty & Asias, > > I assume you mean something like the following patch to allow kbuild to > work when VHOST_NET + VHOST_SCSI are both enabled and sharing vhost.o, > yes..? No, that's a separate issue. memcpy_fromiovec() has nothing to do with networking: that was just the first user. Note that crypto/algif_skcipher.c also uses it. The obvious answer is to move it into lib/. OTOH making vhost_scsi depend on CONFIG_NET is breathtakingly lazy. I expect better from experienced kernel hackers :( Rusty. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
