On Wed, May 15, 2013 at 09:54:24AM -0700, David Daney wrote: > On 05/15/2013 08:54 AM, Sanjay Lal wrote: > > > >On May 14, 2013, at 2:27 AM, Gleb Natapov wrote: > > > >>> > >>> > >>>+EXPORT_SYMBOL(min_low_pfn); /* defined by bootmem.c, but not exported by generic code */ > >>>+ > >>What you need this for? It is not used anywhere in this patch and by > >>mips/kvm code in general. > > > >I did some digging around myself, since the linker keeps complaining that it can't find min_low_pfn when compiling the KVM module. It seems that it is indirectly pulled in by the cache management functions. > > > > If it is really needed, then the export should probably be done at > the site of the min_low_pfn definition, not in some random > architecture file. > Definitely. We cannot snick it here like that. Please drop it from this patch. > An alternative is to fix the cache management functions so they > don't require the export. > > David Daney > > > > >Regards > >Sanjay > > > > > > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
