Re: [PATCH] kvm/ppc: interrupt disabling fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-05-08 at 19:35 -0500, Scott Wood wrote:

> Sigh, and then there's this:
> 
> #ifdef CONFIG_PPC64
>                  /* lazy EE magic */
>                  hard_irq_disable();
>                  if (lazy_irq_pending()) {
>                          /* Got an interrupt in between, try again */
>                          local_irq_enable();
>                          hard_irq_disable();
>                          kvm_guest_exit();
>                          continue;
>                  }
> 
>                  trace_hardirqs_on();
> #endif
> 
> Alex, could you be a bit more descriptive than "magic" please?  Can  
> this chunk of code be removed if we do the other changes being  
> discussed?  Or should we leave this in and drop the pre-enter  
> hard_irq_disable portion of the proposed changes?
> 
> Why are you calling trace_hardirqs_on() here and not in  
> kvmppc_lazy_ee_enable()?  Why are you calling kvm_guest_exit() before  
> you've called kvm_guest_enter()?

I think I originated that magic... it more/less mimmics prep_for_idle,
the goal was to hard disable (because we had soft disabled earlier) and
check if anything happened in between... if it did, abort, and try
again, but it's a bit fishy really.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux