Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output to any console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/03/2013 12:09 PM, Will Deacon wrote:
> On Fri, May 03, 2013 at 05:02:14PM +0100, Sasha Levin wrote:
>> On 05/03/2013 05:19 AM, Pekka Enberg wrote:
>>> On Wed, May 1, 2013 at 6:50 PM, Will Deacon <will.deacon@xxxxxxx> wrote:
>>>> From: Marc Zyngier <Marc.Zyngier@xxxxxxx>
>>>>
>>>> Kvmtool suppresses any output to a console that has not been elected
>>>> as *the* console.
>>>>
>>>> While this makes sense on the input side (we want the input to be sent
>>>> to one console driver only), it seems to be the wrong thing to do on
>>>> the output side, as it effectively prevents the guest from switching
>>>> from one console to another (think earlyprintk using 8250 to virtio
>>>> console).
>>>>
>>>> After all, the guest *does* poke this device and outputs something
>>>> there.
>>>>
>>>> Just remove the kvm->cfg.active_console test from the output paths.
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>>>> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
>>>
>>> Seems reasonable. Asias, Sasha?
>>>
>>
>> I remember at trying it some time ago but dropped it for a reason I don't
>> remember at the moment.
>>
>> Can I have the weekend to play with it to try and figure out why?
> 
> There's no rush from my point of view (hence the RFC) so take as long as you
> need!

Looks good to me!


Thanks,
Sasha

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux