On 2013-05-03 08:19, Xiao Guangrong wrote:
> On 05/01/2013 01:38 PM, Jordan Justen wrote:
>> Don't use #ifdef __KVM_HAVE_READONLY_MEM when defining
>> KVM_CAP_READONLY_MEM.
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen@xxxxxxxxx>
>> Cc: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
>> Cc: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>> ---
>> include/uapi/linux/kvm.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>> index 3c56ba3..26a04e5 100644
>> --- a/include/uapi/linux/kvm.h
>> +++ b/include/uapi/linux/kvm.h
>> @@ -655,9 +655,7 @@ struct kvm_ppc_smmu_info {
>> #define KVM_CAP_PPC_GET_SMMU_INFO 78
>> #define KVM_CAP_S390_COW 79
>> #define KVM_CAP_PPC_ALLOC_HTAB 80
>> -#ifdef __KVM_HAVE_READONLY_MEM
>> #define KVM_CAP_READONLY_MEM 81
>> -#endif
>
> This is not enough since only X86 supports this feature.
>
> I had a similar patch to change it:
> https://patchwork.kernel.org/patch/1642491/
>
> Is it good to you?
The first hunk of that patch is unneeded (x86 always has
__KVM_HAVE_READONLY_MEM set), but the third one is actually missing here.
Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
