On 02.05.2013, at 16:00, Bhushan Bharat-R65777 wrote: > > >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@xxxxxxx] >> Sent: Thursday, May 02, 2013 4:35 PM >> To: Bhushan Bharat-R65777 >> Cc: kvm-ppc@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; Wood Scott-B07421 >> Subject: Re: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support >> >> >> On 02.05.2013, at 11:46, Bhushan Bharat-R65777 wrote: [...] >>> >>>> >>>>> +#endif >>>>> + mtspr(SPRN_IAC1, vcpu->arch.shadow_dbg_reg.iac[0]); >>>>> + mtspr(SPRN_IAC2, vcpu->arch.shadow_dbg_reg.iac[1]); >>>>> +#if CONFIG_PPC_ADV_DEBUG_IACS > 2 >>>>> + mtspr(SPRN_IAC3, vcpu->arch.shadow_dbg_reg.iac[2]); >>>>> + mtspr(SPRN_IAC4, vcpu->arch.shadow_dbg_reg.iac[3]); >>>>> +#endif >>>>> + mtspr(SPRN_DAC1, vcpu->arch.shadow_dbg_reg.dac[0]); >>>>> + mtspr(SPRN_DAC2, vcpu->arch.shadow_dbg_reg.dac[1]); >>>>> + >>>>> + /* Enable debug events after other debug registers restored */ >>>>> + mtspr(SPRN_DBCR0, vcpu->arch.shadow_dbg_reg.dbcr0); } >>>> >>>> All of the code above looks suspiciously similar to >>>> prime_debug_regs();. Can't we somehow reuse that? >>> >>> I think we can if >>> - Save thread->debug_regs in local data structure >> >> Yes, it can even be on the stack. > > Thread->denug_regs is not struct , so memcpy() will not work, it is assigning all registers one by one. We could make it a struct, no? Then it's a matter of a = b; :) Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
