On Fri, Apr 26, 2013 at 12:13:33PM -0500, Scott Wood wrote: > Also please note that we no longer hold kvm->lock during device > creation, so your EEXIST check looks racy. Huh? Patch 2/8 adds this code: + mutex_lock(&kvm->lock); + if (kvm->arch.xics) + ret = -EEXIST; + else + kvm->arch.xics = xics; + mutex_unlock(&kvm->lock); How is that racy? Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html