On Fri, Apr 05, 2013 at 10:08:04AM +0100, Marc Zyngier wrote: > On 04/04/13 23:10, Geoff Levand wrote: > > Hi, > > > > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: > >> + @ Jump to the trampoline page > >> + ldr r2, =#PAGE_MASK > >> + adr r3, target > >> + bic r3, r3, r2 > >> + ldr r2, =#TRAMPOLINE_VA > >> + add r3, r3, r2 > >> + mov pc, r3 > > > > I guess you need 'ldr r2, =PAGE_MASK'. > > > > arch/arm/kvm/init.S:114: Error: bad expression -- `ldr r2,=#(~((1<<12)-1))' > > arch/arm/kvm/init.S:117: Error: bad expression -- `ldr r2,=#0xffff0000' > > Oddly enough, this code compiles perfectly fine on my box. > What's your compiler/binutils versions? The standard format for this is: ldr rd, =value without a '#' and has been that way for as long as I remember binutils accepting that format. It's entirely possible that later binutils has decided to be a bit more flexible by allowing the '#' in there, but that's something which will be incompatible with older versions. Best loose the '#' in there. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
