On 04/11/2013 12:53 PM, Prerna Saxena wrote: > On 04/10/2013 09:05 PM, Sasha Levin wrote: >> Hm, what would LD create before this patch? I thought that the default >> would be to create a binary that corresponds to the platform you're >> building in, so if you build on ppc64 you'd get ppc64 binaries, no? >> > > Hi Sasha, > Thanks for the prompt response. > Powerpc had historically supported 32 bit userspace on a 64 bit kernel, > before everything moved 64 bit. > > I'd hit this issue since the default output of 'ld' was turning out to > be 'elf32-powerpc' on my ppc64 build machine. This was running ld-2.22. > I found that adding '--oformat=elf64-powerpc' to the Makefile helped me > tide over it, so I sent a patch to that end. > Today, I verified on another ppc64 machine that ld is automatically > choosing 'elf64-powerpc'. This machine is running 'ld-2.23' > > So, this patch can be ignored, since it appears to be a toolchain > dependency. Or, we could put it in place, to ensure kvmtool builds dont > break even if the toolchain is not perfectly configured. > As you suggest :) What worries me with about this patch is that it will break build on 32bit machines. I don't know if those are even supported these days or not, but if they are - we need something different to handle that. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
