On Mon, Apr 01, 2013 at 11:58:21PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > Hi folks, > > This series adds a virtio_queue_valid() for use by virtio-pci code in > order to prevent opreations upon uninitialized VQs, which is currently > expected to occur during seabios setup of virtio-scsi with in-flight > vhost-scsi-pci device code. > > On the vhost side, it also adds virtio_queue_valid() sanity checks in > vhost_virtqueue_[start,stop]() and vhost_verify_ring_mappings() in order > to skip the same uninitialized VQs. > > Changes from v1: > - Remove now unnecessary virtio_queue_get_num() calls in virtio-pci.c > - Add virtio_queue_valid() calls in vhost_virtqueue_[start,stop]() > > Please review. > > --nab Looks reasonable. Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> So - does this fix the issues you saw with vhost-scsi? > Michael S. Tsirkin (1): > virtio: add API to check that ring is setup > > Nicholas Bellinger (2): > virtio-pci: Add virtio_queue_valid checks ahead of > virtio_queue_get_num > vhost: Skip uninitialized VQs in vhost_virtqueue_[start,stop] > > hw/vhost.c | 12 ++++++++++++ > hw/virtio-pci.c | 34 +++++++++++++++------------------- > hw/virtio.c | 5 +++++ > hw/virtio.h | 1 + > 4 files changed, 33 insertions(+), 19 deletions(-) > > -- > 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
