Re: [PATCH] KVM: x86: Avoid busy loops over uninjectable pending APIC timers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 17, 2013 at 12:47:17PM +0200, Gleb Natapov wrote:
> On Sun, Mar 17, 2013 at 11:45:34AM +0100, Jan Kiszka wrote:
> > On 2013-03-17 09:47, Gleb Natapov wrote:
> > > On Sat, Mar 16, 2013 at 09:49:07PM +0100, Jan Kiszka wrote:
> > >> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> > >>
> > >> If the guest didn't take the last APIC timer interrupt yet and generates
> > >> another one on top, e.g. via periodic mode, we do not block the VCPU
> > >> even if the guest state is halted. The reason is that
> > >> apic_has_pending_timer continues to return a non-zero value.
> > >>
> > >> Fix this busy loop by taking the IRR content for the LVT vector in
> > >> apic_has_pending_timer into account.
> > >>
> > > Just drop coalescing tacking for lapic interrupt. After posted interrupt
> > > will be merged __apic_accept_irq() will not longer return coalescing
> > > information, so the code will be dead anyway.
> > 
> > That requires the RTC decoalescing series to go first to avoid a
> > regression, no? Then let's postpone this topic for now.
> > 
> Yes, but decoalescing will work only for RTC :(

Are you proposing to drop LAPIC interrupt reinjection? 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux