On Thu, Mar 14, 2013 at 11:32:59AM -0300, Marcelo Tosatti wrote: > > > Also the fact kvm_apic_accept_events() is called from sites is annoying, > > > why is that necessary again? > > > > - to avoid having pending events in the APIC when delivering mp_state > > to user space > > - to keep mp_state correct after waking up from kvm_vcpu_block (we > > could otherwise walk through code paths with the wrong state) > > - to process pending events when the VCPU was running > > > > Jan > > Ok, its alright (multiple callsites). Perhaps second and third points to > be collapsed into a single one if moved outside vcpu_enter_guest. Lets not forget that the point of all this changes was to properly handle INIT wrt nested guests. I wonder how implementing it will affect all the call sites. I doubt we want to handle nested vmexit at each one one them. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
